Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting issues with strings containing double-quotes with backslashes #683

Closed
ghost opened this issue May 30, 2015 · 4 comments
Closed

Comments

@ghost
Copy link

ghost commented May 30, 2015

emacs skyrim_007

@gracjan
Copy link
Contributor

gracjan commented May 30, 2015

Hi @sumitsahrawat , nice catch!

This issue is caused by these lines: https://github.com/haskell/haskell-mode/blob/master/haskell-font-lock.el#L336-L343

I tries to match any three or more consecutive punctuation chars (there are three backslashes in your example) and remove any comment starting from them if they are not only dashes. Or more simply -- is a comment starter whereas \-- or --\ are possible operators in Haskell.

Can you try and fix this yourself? Would be very appreciated!

@ghost
Copy link
Author

ghost commented May 30, 2015

I would love to do so, but I'm not very conversant with elisp. Thanks for the offer.

@gracjan
Copy link
Contributor

gracjan commented May 30, 2015

Well, that part is just a big overgrown regexp, nothing to be scared of! Give it a try!

@ghost
Copy link
Author

ghost commented May 31, 2015

I'll try and return to it.

@gracjan gracjan closed this as completed in 489bf2d Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant