Fix inferior-haskell warning font lock for GHC 8.0 #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GHC 8.0 uses an error message of the form
```
/home/alanz/mysrc/github/alanz/ghc-exactprint/tests/Test.hs:99:3: warning: [-Wunused-matches]
Defined but not used: ‘prettyRoundTripTests’
```
The word "warning" no longer has an initial capital letter.
inf-haskell.el
Outdated
| `(("^ERROR \"\\(.+?\\)\"\\(:\\| line \\)\\([0-9]+\\) - " 1 3) | ||
| ;; Format of error messages used by GHCi. | ||
| ("^\\(.+?\\):\\([0-9]+\\):\\(\\([0-9]+\\):\\)?\\( \\|\n *\\)\\(Warning\\)?" | ||
| ("^\\(.+?\\):\\([0-9]+\\):\\(\\([0-9]+\\):\\)?\\( \\|\n *\\)\\(.arning\\)?" |
There was a problem hiding this comment.
That was my first idea, but there is so much escaping going on in the regex I was not sure if any would be needed. Will update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC 8.0 uses an error message of the form
The word "warning" no longer has an initial capital letter.