Skip to content

Semigroup instance for MarkupContent is wrong #328

@isovector

Description

@isovector

Markdown and plaintext have different semantics wrt newlines. The current semigroup instance simply coerces plaintext to markdown, but this breaks newlines. A more correct solution would be to do something like this for any plaintext arguments that are being transformed into markdown:

forceMarkdownNewlines :: String -> String
forceMarkdownNewlines = unlines . fmap (<> "  ") . lines

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions