Skip to content

Conversation

aonnikov
Copy link
Member

Copy link

Connected to Huly®: UBERF-13807

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements duplicate marks support for the y-prosemirror synchronization, addressing a compatibility issue with the yjs/y-prosemirror library. The changes introduce a hashing mechanism to handle overlapping marks of the same type with different attributes.

  • Adds support for duplicate marks by implementing mark hashing when multiple marks of the same type exist
  • Introduces hash stripping functionality to recover original mark types during deserialization
  • Updates test suite to include overlapping mark scenarios and improves test infrastructure

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
plugins/text-editor-resources/package.json Adds text-ydoc dependency and updates lib0 version
packages/text-ydoc/src/ydoc.ts Implements duplicate mark handling with hashing and hash stripping
packages/text-ydoc/src/tests/ydoc.test.ts Adds overlapping mark test cases and improves test matchers
packages/text-ydoc/package.json Adds text-core dependency
packages/text-core/src/markup/utils.ts Implements hash utilities and updates JSON parsing to strip hashes
packages/text-core/package.json Adds hash-it dependency
Files not reviewed (1)
  • common/config/rush/pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
@aonnikov aonnikov merged commit a4dbcb3 into develop Sep 29, 2025
25 of 26 checks passed
@aonnikov aonnikov deleted the fix-duplicate-marks branch September 29, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants