Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: Compare vs. last commit in black CI action #151

Closed

Conversation

sneakers-the-rat
Copy link
Contributor

Motivation

Noticed that black wasn't being run in https://github.com/hdmf-dev/hdmf-zarr/actions/runs/7335433157/job/19973345812#step:4:66 , presumably because at the time of a PR the changes have already been committed, see https://pre-commit.com/#usage-in-continuous-integration

I assume it's intended to check if PRs are black-compliant? but isn't currently doing that. I ran a manual check of black and it looks like most of the package isn't either, so this will cause all other PRs to fail until upstream has been black reformatted.

How to test the behavior?

make new PR, make black-noncompliant changes, tests should fail.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly
Copy link
Contributor

rly commented Jan 11, 2024

After #153 and #146 have been merged, @mavaylon1 can you reformat the repo using black and push those changes in a separate PR?

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (3f78f9c) to head (4509b29).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #151   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files           5        5           
  Lines        1185     1185           
  Branches      292      292           
=======================================
  Hits         1014     1014           
  Misses        115      115           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor

After #153 and #146 have been merged, @mavaylon1 can you reformat the repo using black and push those changes in a separate PR?

Sure thing

@rly rly requested a review from mavaylon1 November 7, 2024 19:35
@mavaylon1
Copy link
Contributor

For now we decided to not support black and will remove the workflow.

@mavaylon1 mavaylon1 closed this Nov 7, 2024
@sneakers-the-rat
Copy link
Contributor Author

Ha ok yes fair enough, that is one way of handling it without needing to do a bazillion line reformatting PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants