-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array columns aren't properly parsed which causes exception in fetching results #68
Comments
I've been digging a bit and it looks like this issue isn't necessarily in the parsers but at the thrift level:
returns
Whereas mapdql works as expected:
@andrewseidl any ideas here or is this a wait for Thrift v0.11 to fix handling array types issue? |
It's most likely related to Thrift v0.10.0's broken array/recursive struct handling. Thankfully v0.11.0 is finally up on pypi, so updating pymapd to use that is next on my list. |
👍 I'll close this out once PyMapD is updated to thrift v0.11.0 and I confirm it's working as expected. |
Recursive structs are now supported by Thrift 0.11.0 Resolves heavyai#68
Just merged Thrift v0.11.0 support, but it looks like this is still an issue. On the plus side the
I'll take a look. Hoping to push out a new release soon with this resolved and #63 rebased and merged. |
is there any update about this issue? |
I just merged in a related PR that handles arrays, will try and work on this today |
hey @randyzwitch any update? |
This isn't something I have the capacity to work on for at least another month, unfortunately. |
@xmnlab Spent some time with ipdb, I now see why this is happening...of course, how to fix it is the bigger issue :) |
Provides ability to return list columns within sql_execute. Closes #68
Minimal example to reproduce error:
yields:
I'm guessing the issue is related to the following definitions not checking if the columns are array types: https://github.com/mapd/pymapd/blob/b52f92c47f4a192e8f33ef14a04327daa8893dd0/pymapd/_parsers.py#L36-L72
The text was updated successfully, but these errors were encountered: