VolatileLayerClient::PrefetchTiles fv tests.

[kzvieriev]

Functional tests for VolatileLayerClient::PrefetchTiles() method. New
catalog/credentials created for the tests, since Read/Write volatile
layer with HERETile scheme required.

Resolves: OLPEDGE-1738

Signed-off-by: Kostiantyn Zvieriev ext-kostiantyn.zvieriev@here.com

[codecov]

Codecov Report

Merging #772 into master will increase coverage by 0.4%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #772     +/-   ##
========================================
+ Coverage    78.2%   78.7%   +0.4%     
========================================
  Files         289     292      +3     
  Lines        9709    9931    +222     
========================================
+ Hits         7597    7811    +214     
- Misses       2112    2120      +8     

Impacted Files	Coverage Δ
...nclude/olp/dataservice/read/PrefetchTilesRequest.h	68.0% <0.0%> (-24.0%)	⬇️
...aservice/write/model/PublishPartitionDataRequest.h	84.2% <0.0%> (-15.8%)	⬇️
...p-cpp-sdk-core/src/cache/DiskCacheSizeLimitEnv.cpp	83.3% <0.0%> (-3.3%)	⬇️
olp-cpp-sdk-core/src/utils/Dir.cpp	78.3% <0.0%> (-2.4%)	⬇️
olp-cpp-sdk-core/src/cache/DiskCache.cpp	65.8% <0.0%> (-2.1%)	⬇️
olp-cpp-sdk-core/src/utils/Url.cpp	57.7% <0.0%> (-0.5%)	⬇️
olp-cpp-sdk-core/src/utils/Base64.cpp	19.1% <0.0%> (ø)
olp-cpp-sdk-core/src/cache/DefaultCacheImpl.h	100.0% <0.0%> (ø)
olp-cpp-sdk-core/include/olp/core/http/Network.h	100.0% <0.0%> (ø)
...-cpp-sdk-core/include/olp/core/http/NetworkTypes.h	100.0% <0.0%> (ø)
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4e055...9abc7ba. Read the comment docs.

[meravingen123]

Can this be done in fixture SetUp?

[kzvieriev]

Prefetch tests need different setup. They use another catalog, credentials etc. + we need to write tiles data used only by these tests, so moving it to SetUp() will lead to overhead for other test.

[LiubovDidkivska]

could we have one app id and secret for all tests in VolatileLayerClientTest? So other user can set only once their id/secret.

[kzvieriev]

Will need to change old tests, so they use new catalog, layers etc.
Old credentials/catalog can't be used in new tests, since need to write data with tiles first.

Anyway, there is a separated task to create accessible catalogs for all tests. After that we could use same credentials for all tests here.

[LiubovDidkivska]

Also could we use SetUp function for prefetch tests also.

[kzvieriev]

Same reason here, prefetch tests require tiles in the layer.
Adding data isn't fast process, so I prefer to make this preparation only for these new tests. What do you think about it?

[andescu]

Do we need such a functional test. This can be, resp. should be, an integration test.

[kzvieriev]

yeap. integration tests has same test. Removed.

[andescu]

Same here, should be an integration test.

[kzvieriev]

Removed also.

[andescu]

These are all integration tests.
The only test you need to do extra is that in case min/max are equal or 0, that only the requested tilekeys are downloaded.

[kzvieriev]

Removed.
Extra tests for 0/0 and same levels added.

[andescu]

You are testing too much. You don't need to replicate the integration tests here. You only need to test the real functionality with OLP, resp. with the mocked server later on. So that you have covered the e2e scenario.
You don't need to replicate the entire integration tests here. This is not the point.

[kzvieriev]

Removed.
Actually, I took them from VersionedLayerClient prefetch fv tests. So they need cleanup too.

[andescu]

You don't set any TaskScheduler. Please set TaskScheduler else all requests are sync, which we don't want.

[andescu]

Suggested change

	export dataservice_read_volatile_test_prefetch_catalog=hrn:here:data::olp-here-test:test-volatile-prefetch"
	export dataservice_read_volatile_test_prefetch_catalog="hrn:here:data::olp-here-test:test-volatile-prefetch"