Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu-dawn: need to fix Zig issue "error.Unexpected: GetLastError(206): The filename or extension is too long." #167

Closed
Tracked by #86
slimsag opened this issue Feb 20, 2022 · 3 comments · Fixed by ziglang/zig#10950
Closed
Tracked by #86

gpu-dawn: need to fix Zig issue "error.Unexpected: GetLastError(206): The filename or extension is too long." #167

slimsag opened this issue Feb 20, 2022 · 3 comments · Fixed by ziglang/zig#10950
Assignees
@slimsag
Labels
bug Something isn't working build gpu-dawn os/windows
Milestone
Mach 0.1

Comments

@slimsag
Copy link
Member

slimsag commented Feb 20, 2022

This is one issue preventing gpu-dawn from building on Windows.

On Windows there is a 32 KiB limit to the arguments that are passed to a program via CreateProcess. The Zig Builder quickly exceeds this in a zig build-lib command when we're trying to build Dawn on Windows as a single static library.
@slimsag slimsag added bug Something isn't working build gpu-dawn labels Feb 20, 2022
@slimsag slimsag self-assigned this Feb 20, 2022
This was referenced Feb 20, 2022
Merged
Closed
@slimsag slimsag added this to the Mach 0.1 milestone Feb 20, 2022
@slimsag
Copy link
Member Author

slimsag commented Feb 27, 2022

Fix merged upstream.

@slimsag slimsag closed this as completed Feb 27, 2022
@slimsag
Copy link
Member Author

slimsag commented Mar 5, 2022

It caused a regression and got reverted, resent ziglang/zig#11065

@slimsag slimsag reopened this Mar 5, 2022
slimsag added a commit that referenced this issue Mar 6, 2022
@slimsag
gpu-dawn: CI: temporarily use patched Windows version of Zig
83f1104 
So that we can produce binary releases for Windows until upstream PR is
merged: #167

Helps #86

Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
slimsag added a commit to hexops-graveyard/mach-gpu-dawn that referenced this issue Mar 6, 2022
@slimsag
gpu-dawn: CI: temporarily use patched Windows version of Zig
acad8a9 
So that we can produce binary releases for Windows until upstream PR is
merged: hexops/mach#167

Helps hexops/mach#86

Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
@slimsag
Copy link
Member Author

slimsag commented Mar 19, 2022

This landed, just need to update CI systems back to using upstream Zig.

@slimsag slimsag closed this as completed Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slimsag slimsag

Labels
bug Something isn't working build gpu-dawn os/windows
Projects
None yet
Milestone
Mach 0.1
Development

Successfully merging a pull request may close this issue.

Do not fail to build if 'zig build-lib' etc. arguments exceed OS limits
1 participant
@slimsag