Do not fail to build if 'zig build-lib' etc. arguments exceed OS limits (take 2) #11065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2022 16:04
This reverts commit 5ab5e2e.
This brings back #10950, which was reverted in 5ab5e2e because it [introduced a regression in `zig run`](#10950 (comment)) where the runtime arguments passed were incorrect. I've fixed the issue, and notably this was the only location where we directly relied on accessing arguments by index in this code still (all other locations use the iterator proper) and so we should be all good to go now. Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
Member
|
Thanks for the follow-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back #10950, which was reverted in 5ab5e2e because it introduced a regression in
zig runwhere the runtime arguments passed were incorrect (sorry for not catching that sooner!)I've fixed the issue, and notably this was the only location where we directly relied on accessing arguments by index in this code still (all other locations use the iterator proper) and so we should be all good to go now.
cc @andrewrk sorry for the regression!