fix(compiler): ensure backticked strings are escaped properly #310
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @icedream, didn't even give me a chance to debug! Can you add a patch changeset so we can release a new version? |
icedream
force-pushed
the
pr/fix-backticks-and-single-quotes-bad-escape
branch
from
f028e8a to
4f6bc00
Compare
|
It was an issue quickly identified in the code so I thought I would send the fix right along with the issue ticket. 😄 You're welcome! EDIT: Changeset added! |
icedream
force-pushed
the
pr/fix-backticks-and-single-quotes-bad-escape
branch
from
4f6bc00 to
2c76592
Compare
|
Just noticed the *.snaps are wrong, will fix it next push. |
icedream
force-pushed
the
pr/fix-backticks-and-single-quotes-bad-escape
branch
from
2c76592 to
a8e9e33
Compare
|
Made sure that the tests are passing locally now at least. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -70,7 +70,7 @@ | |||
| !value.startsWith('`') && | |||
| !value.endsWith('`') | |||
| ) { | |||
| value = `\`${value}\``; | |||
| value = `\`${value.replace(/`/g, '\\`')}\``; | |||
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
=======================================
Coverage 85.77% 85.77%
=======================================
Files 72 72
Lines 4619 4619
Branches 542 542
=======================================
Hits 3962 3962
Misses 655 655
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes #309.
The code made an assumption that if single/double quotes are used it can safely add backticks instead. This turned out to be not true for descriptions that used both.
This change makes quick work of it by just escaping all backticks in this particular conditional branch.