skip/fix some tests on Informix

Author: gavinking

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/manytoonewithformula/ManyToOneWithFormulaTest.java

@@ -5,6 +5,7 @@
 package org.hibernate.orm.test.annotations.manytoonewithformula;
 
 import org.hibernate.community.dialect.AltibaseDialect;
+import org.hibernate.community.dialect.InformixDialect;
 import org.hibernate.dialect.HSQLDialect;
 import org.hibernate.dialect.OracleDialect;
 import org.hibernate.dialect.SQLServerDialect;
@@ -22,7 +23,6 @@
 /**
  * @author Sharath Reddy
  */
-@SuppressWarnings("JUnitMalformedDeclaration")
 public class ManyToOneWithFormulaTest {
 	@Test
 	@DomainModel( annotatedClasses = { Menu.class, FoodItem.class } )
@@ -148,8 +148,9 @@ public void testReferencedColumnNameBelongsToEmbeddedIdOfReferencedEntity(Sessio
 	@Test
 	@DomainModel( annotatedClasses = Product.class )
 	@SessionFactory
-	@SkipForDialect( dialectClass =HSQLDialect.class, reason = "The used join conditions does not work in HSQLDB. See HHH-4497." )
-	@SkipForDialect( dialectClass = OracleDialect.class, reason = "Oracle do not support 'substring' function" )
+	@SkipForDialect( dialectClass = HSQLDialect.class, reason = "The used join conditions does not work in HSQLDB. See HHH-4497." )
+	@SkipForDialect( dialectClass = OracleDialect.class, reason = "Oracle do not support 'substring' function JDBC escape" )
+	@SkipForDialect( dialectClass = InformixDialect.class, reason = "Oracle do not support 'substring' function JDBC escape" )
 	@SkipForDialect( dialectClass = AltibaseDialect.class, reason = " Altibase char type returns with trailing spaces")
 	public void testManyToOneFromNonPkToNonPk(SessionFactoryScope scope) {
 		// also tests usage of the stand-alone @JoinFormula annotation

hibernate-core/src/test/java/org/hibernate/orm/test/hql/CoalesceTest.java

@@ -20,7 +20,6 @@
 /**
  * @author Johannes Buehler
  */
-@SuppressWarnings("JUnitMalformedDeclaration")
 @JiraKey( value = "HHH-10463")
 @DomainModel(annotatedClasses = org.hibernate.testing.orm.domain.gambit.EntityOfBasics.class)
 @SessionFactory

hibernate-core/src/test/java/org/hibernate/orm/test/mapping/generated/sql/SqlGeneratedTest.java

@@ -7,6 +7,7 @@
 import jakarta.persistence.Entity;
 import jakarta.persistence.Id;
 import org.hibernate.annotations.Generated;
+import org.hibernate.community.dialect.InformixDialect;
 import org.hibernate.dialect.SybaseASEDialect;
 import org.hibernate.generator.EventType;
 import org.hibernate.testing.orm.junit.DomainModel;
@@ -26,11 +27,12 @@
 /**
  * @author Gavin King
  */
-@SuppressWarnings("JUnitMalformedDeclaration")
 @DomainModel(annotatedClasses = SqlGeneratedTest.OrderLine.class)
 @SessionFactory
 @SkipForDialect(dialectClass = SybaseASEDialect.class,
 		reason = "The name 'current_timestamp' is illegal in this context. Only constants, constant expressions, or variables allowed here.")
+@SkipForDialect( dialectClass = InformixDialect.class,
+		reason = "No 'current_timestamp' function on Informix (test passes with 'current')")
 public class SqlGeneratedTest {
 
 	@Test

hibernate-core/src/test/java/org/hibernate/orm/test/onetoone/singletable/SingleTableOneToOneTest.java

@@ -6,6 +6,7 @@
 
 import java.util.List;
 
+import org.hibernate.community.dialect.InformixDialect;
 import org.hibernate.dialect.SybaseDialect;
 import org.hibernate.exception.ConstraintViolationException;
 
@@ -55,7 +56,10 @@ public void tearDown(SessionFactoryScope scope) {
 	}
 
 	@Test
-	@SkipForDialect(dialectClass = SybaseDialect.class, matchSubTypes = true, reason = "Sybase ignores unique constraints on nullable columns")
+	@SkipForDialect(dialectClass = SybaseDialect.class, matchSubTypes = true,
+			reason = "SybaseDialect ignores unique constraints on nullable columns")
+	@SkipForDialect(dialectClass = InformixDialect.class, matchSubTypes = true,
+			reason = "InformixDialect ignores unique constraints on nullable columns")
 	public void testMultipleRelationshipsOnSingleTableInheritanceWronglyMappedAsOneToOne(SessionFactoryScope scope) {
 		assertThrows(
 				ConstraintViolationException.class,

hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/CountExpressionTest.java

@@ -15,8 +15,10 @@
 import jakarta.persistence.MapKeyColumn;
 import jakarta.persistence.OneToMany;
 
+import org.hibernate.community.dialect.InformixDialect;
 import org.hibernate.testing.orm.junit.JiraKey;
 import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
+import org.hibernate.testing.orm.junit.SkipForDialect;
 import org.junit.Test;
 
 import static org.hibernate.testing.transaction.TransactionUtil.doInHibernate;
@@ -87,6 +89,8 @@ public void testCountDistinctExpression() {
 
 	@Test
 	@JiraKey(value = "HHH-11042")
+	@SkipForDialect(dialectClass = InformixDialect.class,
+			reason = "Informix allows only one column in count(distinct)")
 	public void testCountDistinctTuple() {
 		doInHibernate( this::sessionFactory, session -> {
 			List results = session.createQuery(
@@ -108,6 +112,8 @@ public void testCountDistinctTuple() {
 
 	@Test
 	@JiraKey(value = "HHH-11042")
+	@SkipForDialect(dialectClass = InformixDialect.class,
+			reason = "Informix allows only one column in count(distinct)")
 	public void testCountDistinctTupleSanity() {
 		doInHibernate( this::sessionFactory, session -> {
 			// A simple concatenation of tuple arguments would produce a distinct count of 1 in this case

hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/FunctionTests.java

@@ -1024,7 +1024,7 @@ public void testCastFunction(SessionFactoryScope scope) {
 					assertThat( session.createQuery("select cast('1911-10-09 12:13:14.123' as Timestamp)", Timestamp.class).getSingleResult(), instanceOf(Timestamp.class) );
 
 					assertThat( session.createQuery("select cast(date 1911-10-09 as String)", String.class).getSingleResult(), is("1911-10-09") );
-					assertThat( session.createQuery("select cast(time 12:13:14 as String)", String.class).getSingleResult(), anyOf( is("12:13:14"), is("12:13:14.0000"), is("12.13.14") ) );
+					assertThat( session.createQuery("select cast(time 12:13:14 as String)", String.class).getSingleResult(), anyOf( is("12:13:14"), is("12:13:14.0000"), is("12:13:14.000"), is("12.13.14") ) );
 					assertThat( session.createQuery("select cast(datetime 1911-10-09 12:13:14 as String)", String.class).getSingleResult(), anyOf( startsWith("1911-10-09 12:13:14"), startsWith("1911-10-09-12.13.14") ) );
 
 					assertThat( session.createQuery("select cast(local datetime as Instant)", Instant.class).getSingleResult(), instanceOf(Instant.class) );
@@ -1224,7 +1224,7 @@ public void testStrFunction(SessionFactoryScope scope) {
 							.list();
 					assertThat( session.createQuery("select str(69)", String.class).getSingleResult(), is("69") );
 					assertThat( session.createQuery("select str(date 1911-10-09)", String.class).getSingleResult(), is("1911-10-09") );
-					assertThat( session.createQuery("select str(time 12:13:14)", String.class).getSingleResult(), anyOf( is( "12:13:14"), is( "12:13:14.0000"), is( "12.13.14") ) );
+					assertThat( session.createQuery("select str(time 12:13:14)", String.class).getSingleResult(), anyOf( is( "12:13:14"), is( "12:13:14.0000"), is( "12:13:14.000"), is( "12.13.14") ) );
 				}
 		);
 	}
@@ -2078,11 +2078,6 @@ public void testExtractFunction(SessionFactoryScope scope) {
 					session.createQuery("select extract(day from e.theDate) from EntityOfBasics e", Integer.class)
 							.list();
 
-					session.createQuery("select extract(day of year from e.theDate) from EntityOfBasics e", Integer.class)
-							.list();
-					session.createQuery("select extract(day of month from e.theDate) from EntityOfBasics e", Integer.class)
-							.list();
-
 					session.createQuery("select extract(quarter from e.theDate) from EntityOfBasics e", Integer.class)
 							.list();
 
@@ -2113,11 +2108,6 @@ public void testExtractFunction(SessionFactoryScope scope) {
 					session.createQuery("select extract(time from local datetime), extract(date from local datetime) from EntityOfBasics e", Object[].class)
 							.list();
 
-					session.createQuery("select extract(week of month from current date) from EntityOfBasics e", Integer.class)
-							.list();
-					session.createQuery("select extract(week of year from current date) from EntityOfBasics e", Integer.class)
-							.list();
-
 					assertThat( session.createQuery("select extract(year from date 1974-03-25)", Integer.class).getSingleResult(), is(1974) );
 					assertThat( session.createQuery("select extract(month from date 1974-03-25)", Integer.class).getSingleResult(), is(3) );
 					assertThat( session.createQuery("select extract(day from date 1974-03-25)", Integer.class).getSingleResult(), is(25) );
@@ -2128,6 +2118,24 @@ public void testExtractFunction(SessionFactoryScope scope) {
 		);
 	}
 
+	@Test
+	public void testExtractFunctionDayOfWeekOf(SessionFactoryScope scope) {
+		scope.inTransaction(
+				session -> {
+					session.createQuery("select extract(day of year from e.theDate) from EntityOfBasics e", Integer.class)
+							.list();
+					session.createQuery("select extract(day of month from e.theDate) from EntityOfBasics e", Integer.class)
+							.list();
+
+					session.createQuery("select extract(week of month from current date) from EntityOfBasics e", Integer.class)
+							.list();
+					session.createQuery("select extract(week of year from current date) from EntityOfBasics e", Integer.class)
+							.list();
+
+				}
+		);
+	}
+
 	@Test
 	public void testExtractFunctionEpoch(SessionFactoryScope scope) {
 		scope.inTransaction(