HHH-16710 implicit instantiation for HQL result types #6680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @Entity(name = "Thing") | ||
| @Table(name = "thingy_table") | ||
| public class Thing { |
Check notice
Code scanning / CodeQL
Inner class could be static
|
|
||
| This is bearable, but let's explore some other options. | ||
|
|
||
| JPA lets us specify that we want each query result packaged as an instance of `javax.persistence.Tuple`. |
There was a problem hiding this comment.
jakarta. perhaps instead of javax.?
There was a problem hiding this comment.
yeah, thanks, I'm still in denial...
| .getResultList(); | ||
| for (var list : results) { | ||
| String title = (String) list.get(0); | ||
| String preamble = (String) tuple.get(1); |
There was a problem hiding this comment.
I assume tuple should be list
| [source, java] | ||
| [%unbreakable] | ||
| ---- | ||
| var results = |
There was a problem hiding this comment.
IMO it would be nicer to have the full type instead of var
| [source, java] | ||
| [%unbreakable] | ||
| ---- | ||
| var results = |
There was a problem hiding this comment.
IMO it would be nicer to have the full type instead of var
| Map.class) | ||
| .getResultList(); | ||
| for (var map : results) { | ||
| String title = (String) tuple.get("title"); |
There was a problem hiding this comment.
I assume map instead of tupple
|
Note that this PR was superseded by #6685. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.