-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-16710, HHH-16742, HHH-16747 implicit instantiation for HQL result types #6685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a2b1f7
to
15f8b54
Compare
hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/ImplicitInstantiationTest.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/main/java/org/hibernate/sql/results/internal/TupleMetadata.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/main/java/org/hibernate/sql/results/internal/TupleMetadata.java
Fixed
Show fixed
Hide fixed
ac0d99b
to
8d61946
Compare
This was referenced May 30, 2023
0153b0b
to
ca0a8d6
Compare
ca0a8d6
to
d79cc1d
Compare
fix issue when "same" selection item is assigned two different aliases
d79cc1d
to
31350cf
Compare
There's now too much stuff rolled into this PR, and I'm starting to suffer from merge conflicts, so I'm going to merge this soon. We're going to have to make some time to discuss the fallout, however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch incorporates several different improvements to the handling of query "result types".
createSelectionQuery()
, theselect new Xxx(...)
is now optional, and results will be happily packaged as aMap
,List
, or record, just like what happens already withTuple
.createNativeQuery()
.Tuple
instantiation.Object[]
, and never has a weird third behavior which cannot be recovered for any explicit result type.createXxxxQuery()
method with no explicit result type, since, even so, they still have pretty unintuitive behavior when theselect
clause is missing. I propose to eventually undeprecate them and have them throw an exception when theselect
clause is missing (except, perhaps, in extremely unambiguous cases).