HV-414 Create dedicated distribution module #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dicated distribution module Within the assembly we cannot use moduleset anymore we have to use dependencyset. See also discussion under http://www.sonatype.com/books/mvnref-book/reference/assemblies-set-dist-assemblies.html This is also not a perfect solution, because I have for example to repeat the dependencies in the distribution pom in oder to use them in the distribution.
This is the same as suggested in http://www.sonatype.com/books/mvnref-book/reference/assemblies-set-dist-assemblies.html and the same we do in Core 3.6 Not perfect, but it is very tiresome to fight maven all the time
…dicated distribution module The deploy plugin doe not have to call assembly anymore directly. Instead the assembly is bound to a life cycle in the distribution module Also updating some plugin version (compiler plugin)
|
Seems good, I could build the distribution locally without problems with mvn assembly:assembly from within the distribution module. I think specifying the optional dependencies again in the distribution's pom.xml makes actually sense in a way, as there might be optional dependencies that shouldn't go into the distribution. But there is still some redundancy in the distribution's pom.xml and the dist.xml, sigh. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the 4.0.2.Beta1 release we had another Maven issue :(
This time the assembly did not complete using Maven 3.x. The reason was that for some reason the forked assembly build did not have all test dependencies set.
Anyways, this is an attempt to this this by aligning with recommendations from http://www.sonatype.com/books/mvnref-book/reference/assemblies-set-dist-assemblies.html. The old Core 3.6 build also uses this approach. It is still not optimal, because to make it work you have to repeat dependencies in the pom of the distribution module. Also the process of actually including dependencies in the assembly descriptor (dist.xml) is as fiddly as before. It seems there is no perfect solution for this.
A nice side effect of this approach is that the assembly is bound to a lifecycle phase. This means that the assembly plugin is not forking the build and re-running the build up to the package phase. It's a considerable time gain for deploying.
WDYT?