HV-390 #3
Merged
HV-390 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when a local ConstrainValidator is present. Added more tests for boolean composition with and without local ConstraintValidators.
|
Pulled your changes into my local repo. Will close this pull request shortly. |
|
Pushed your changes into master after some formatting and some refactorings. Thanks for sorting this out and adding so many tests. |
|
Yes, I think we covered all possible situations now, and it seems to work correctly. Sorry we could not come up with a better solution for error messages in the ALL_FALSE case. Anyway, thank you for helping us integrating our work in the Hibernate validator, it is nice to know someone is going to actually use it. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I managed to use Git to upload the changes to the validator to evaluate Boolean constraints also when a local constraint validator is present.
There are also new tests.
I think I still have to understand how to handle the comments on the single modified files when I commit, but this should do for now.