Repository navigation
[bug]Changing the number with the arrow buttons doesn't save until I click the box again #511
|
Hi, I found a small but annoying issue in the Settings. When I change a number by clicking the little up/down arrows on the right side of the box, the new value doesn't actually save. I have to click inside the box first and then click somewhere else — only then does it keep the new number. I first noticed this on the battery notification threshold, but after looking around, it seems like every box like this in Settings has the same problem. So it's not just one setting. Possible cause It looks like this might be a problem with the NumberBox control from WPF UI, rather than something specific to one setting. The arrows seem to change the number on screen, but the app doesn't notice the change until the box is clicked into and out of again. I don't know if this is something that can be fixed on your side or if it still needs an upstream fix. Thanks! |
Replies: 1 comment
|
Thanks for the clear report, @2315506431. Your read of the cause was right. WPF UI's NumberBox saves its value only when the box loses focus, and its arrow buttons change the number without giving the box focus, so nothing was saved until you clicked into the box and back out. It's fixed on PadForge's side, so it doesn't wait on WPF UI. Every number box in PadForge now saves each change, whether it comes from the arrows, the Up and Down keys, or a typed number and Enter. The port boxes on the Dashboard wait one second after the last change, so holding an arrow restarts that server once instead of on every step. The fix is commit 622bdaa, in the latest-v5-dev development build and the next release. |
Thanks for the clear report, @2315506431. Your read of the cause was right. WPF UI's NumberBox saves its value only when the box loses focus, and its arrow buttons change the number without giving the box focus, so nothing was saved until you clicked into the box and back out.
It's fixed on PadForge's side, so it doesn't wait on WPF UI. Every number box in PadForge now saves each change, whether it comes from the arrows, the Up and Down keys, or a typed number and Enter. The port boxes on the Dashboard wait one second after the last change, so holding an arrow restarts that server once instead of on every step.
The fix is commit 622bdaa, in the latest-v5-dev development build and the next…