Switch to elm-live to add Apple Silicon M1 support 🤘🏿 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kutyel
approved these changes
May 19, 2021
Haha! It's not removed. It just became smaller. This is exactly how simpler the |
|
I cannot merge it because I have no write access, so please do it yourself. |
Wow, incredible in deed! 🤯 |
kutyel
reviewed
May 19, 2021
| @@ -4,14 +4,14 @@ | |||
| "description": "Elm client example for our mu-haskell GraphQL server!", | |||
| "scripts": { | |||
| "codegen": "elm-graphql --schema-file ../library.graphql --base LibraryApi --output src", | |||
| "start": "elm-app start" | |||
| "start": "elm-live src/Main.elm --dir=public --open --host=0.0.0.0 --port=8080 --pushstate --start-page=index.html -- --output=public/bundle.js" | |||
There was a problem hiding this comment.
Even though the dependencies are much less heavy and the package is better maintained... this line here is terrible DX in my opinion 🤣 Why not make all those arguments the default!? 🤔
|
Thanks again for the contribution! 🙌🏻 |
kutyel
pushed a commit
that referenced
this pull request
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create-elm-appis maintained poorly in comparison toelm-live.I think it's a good switch.
But most importantly, I need these changes so that I could work on #8