Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten createEntity API #125

Merged
merged 6 commits into from
Sep 24, 2022
Merged

Tighten createEntity API #125

merged 6 commits into from
Sep 24, 2022

Conversation

hmans
Copy link
Owner

@hmans hmans commented Sep 24, 2022

This simplifies and tightens createEntity to support only a single argument that must satisfy the entity type. This is done for increased API clarity and reduced code complexity. Composition is deferred to userland, where enough tools are available.

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2022

🦋 Changeset detected

Latest commit: c5f756c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
miniplex Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hmans hmans linked an issue Sep 24, 2022 that may be closed by this pull request
* next:
  Add types for jest-dom testing library
  Cleanup miniplex package.json
  Simplify miniplex-react package.json
@hmans hmans merged commit b8b2c9b into next Sep 24, 2022
@hmans hmans deleted the strict-create-entity branch September 24, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve API clarity of createEntity
1 participant