Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

New observed flag to enable global MutationObserver #53

Merged
merged 6 commits into from
Feb 4, 2021
Merged

Conversation

hmans
Copy link
Owner

@hmans hmans commented Feb 4, 2021

  • Introduces a new observed attribute on <three-game>
  • When enabled, the game will launch an extra MutationObserver to monitor attribute changes anywhere within its DOM.
  • A warning is logged to remind the user that this is intended for development only, and should not be used in production projects because of the detrimental performance implications of using said MutationObserver.
  • The test is a bit basic, but there isn't much we can realistically test, since this only kicks in when an actual human changes an attribute in their devtools.

Will fix #44 when merged.

@hmans hmans merged commit 1cb72a9 into main Feb 4, 2021
@hmans hmans deleted the opt-in-observer branch February 4, 2021 15:02
@RangerMauve
Copy link

Woot! Thank you. 💜

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Support MutationObserver behind a flag
2 participants