Skip to content

Commit c088897

Browse files
[DC-7967] Incorporate Review Comments, remove redundant message url and related code
1 parent 5c9e6ef commit c088897

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

it/test/MessageFrontendISpec.scala

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import play.api.http.{ HeaderNames, Status }
2929
import play.api.inject.guice.GuiceApplicationBuilder
3030
import play.api.libs.json.*
3131
import play.api.libs.ws.JsonBodyWritables.writeableOf_JsValue
32-
import play.api.libs.ws.{ WSClient, WSResponse }
32+
import play.api.libs.ws.WSClient
3333
import play.api.mvc.AnyContentAsEmpty
3434
import play.api.test.FakeRequest
3535
import play.api.test.Helpers.*
@@ -64,7 +64,6 @@ class MessageFrontendISpec
6464
lazy val ws: WSClient = app.injector.instanceOf[WSClient]
6565
lazy val testAuthorisationProvider: TestAuthorisationProvider = app.injector.instanceOf[TestAuthorisationProvider]
6666

67-
val messageResource = "http://localhost:8910/"
6867
val secureMessageResource = "http://localhost:9051/"
6968

7069
override protected def beforeEach(): Unit =
@@ -358,13 +357,6 @@ class MessageFrontendISpec
358357
(response.json \\ "id").map(_.as[JsString].value).head
359358
}
360359

361-
def externalMessagesPost(body: JsObject): WSResponse =
362-
httpClient
363-
.url(s"${messageResource}external/messages")
364-
.withHttpHeaders(SessionKeys.authToken -> ggAuthorisationHeader._2)
365-
.post(body)
366-
.futureValue
367-
368360
def messages(
369361
taxIdentifiers: List[String] = List(),
370362
regimes: List[String] = List()
@@ -460,7 +452,6 @@ class MessageFrontendISpec
460452
messagesPost(fhddsMessage(fhdds))
461453
messagesPost(pptMessage(ppt))
462454
messagesPost(vatMessage(vat))
463-
externalMessagesPost(podsMessage("HMRC-PODS-ORG.PSAID", pods.value))
464455
messagesPost(epayeMessage(epaye))
465456

466457
(authProvider, nino.value, ctUtr.value, fhdds.value, vat.value, ppt.value, pods.value, epaye.value)

it/test/MessagesISpec.scala

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,6 @@ class MessagesISpec extends MessageFrontendISpec with Inspectors {
321321
.withNino(Nino("NH123456D"))
322322
.withPodsPp(HmrcPodsPpOrg("A12345678"))
323323

324-
externalMessagesPost(podsMessage("HMRC-PODS-ORG.PSAID", "A1234567"))
325-
externalMessagesPost(podsMessage("HMRC-PODSPP-ORG.PSPID", "A12345678"))
326-
327324
val request = messagesBta(List("PSPID"), List("pods"))
328325
.withSession(
329326
authContext.bearerTokenHeader(),

0 commit comments

Comments
 (0)