Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Errors during player import in TransferScout #1858

Closed
johari75 opened this issue Apr 26, 2023 · 0 comments
Closed

[BUG] Errors during player import in TransferScout #1858

johari75 opened this issue Apr 26, 2023 · 0 comments
Assignees
@wsbrenk
Labels
status: needs test might be fixed, needs test before closing
Milestone
7.1

Comments

@johari75
Copy link

johari75 commented Apr 26, 2023 •
edited
Loading

Describe the bug
There are several errors during player import in TransferScout.

  1. Deadline not synchronised. It seems that the field in the list allways contains the timestamp of HO start.
  2. If HO is closed and restarted, deadline field in player details is empty. If you set that value manually, all players of your list get the same deadline in their details.
  3. If deadline field is empty (see issue 2) and HO is closed and restarted, player completely disappears. (it is out of the list and you have to search in hattrick.org again)
  4. Price (trailing zero)

Screenshots
1.
Bug_TransferScout_Deadline

Bug_TransferScout_Deadline_deleted

Bug_TransferScout_player_lost

Bug_TransferScout_Price

Platform information:

  • OS:
    Platform_Information

  • Version (including build number)
    HO_Version

Additional context
Add any other context about the problem here.
@wsbrenk wsbrenk added this to the 7.1 milestone Apr 26, 2023
@wsbrenk wsbrenk self-assigned this Apr 29, 2023
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 1, 2023
@wsbrenk
ho-dev#1858 debug date time parsing
d556cc8
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 1, 2023
@wsbrenk
ho-dev#1858 debug currency parsing
4487237
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 1, 2023
@wsbrenk
ho-dev#1858 using Helper.formatCurrency
b9e8c1c
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 1, 2023
@wsbrenk
ho-dev#1858 Player.baseWage reset setter getter (not used for now, bu…
237f2ce 
…t senseful for the future)
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 1, 2023
@wsbrenk
ho-dev#1858 Player.baseWage reset setter getter (not used for now, bu…
436488f 
…t senseful for the future)
@wsbrenk wsbrenk mentioned this issue May 1, 2023
Merged
2 tasks
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 2, 2023
@wsbrenk
ho-dev#1858 translate comments in Helper.java
c131635
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 2, 2023
@wsbrenk
ho-dev#1858 remove unused imports in HODateTime.java (add some comments)
bfc79f0
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 2, 2023
@wsbrenk
ho-dev#1858 fix Player.setExpiryDate, use localized DateTimeFormatter
c13b538
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 2, 2023
@wsbrenk
ho-dev#1858 fix PlayerConverter add comment explaining offsSpecialty
76abce0
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 2, 2023
@wsbrenk
ho-dev#1858 fix PlayerConverter remove old commented methods
ba51423
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 4, 2023
@wsbrenk
ho-dev#1858 fix PlayerConverter.parseLocalDateTime
2a8db02
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 4, 2023
@wsbrenk
ho-dev#1858 PlayerConverter scan wage
1a2b38f
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 6, 2023
@wsbrenk
ho-dev#1858 PlayerConverter scan skill refactored
cbf9442
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 6, 2023
@wsbrenk
ho-dev#1858 PlayerConverter scan wage
a177bb1 
fix indexRowWarning
wsbrenk added a commit that referenced this issue May 8, 2023
@wsbrenk @tychobrailleur
#1858 (#1869)
4ee3c85 
* #1858 debug date time parsing

* #1858 debug currency parsing

* #1858 using Helper.formatCurrency

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 translate comments in Helper.java

* #1858 remove  unused imports in HODateTime.java (add some comments)

* #1858 fix Player.setExpiryDate, use localized DateTimeFormatter

* #1858 fix PlayerConverter add comment explaining offsSpecialty

* #1858 fix PlayerConverter remove old commented methods

* #1858 fix PlayerConverter.parseLocalDateTime

* #1858 PlayerConverter scan wage

* #1858 PlayerConverter scan skill refactored

* #1858 PlayerConverter scan wage
fix indexRowWarning

* Fixes deadline date parsing in Transfer Scout.

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label May 8, 2023
wsbrenk added a commit that referenced this issue May 8, 2023
@wsbrenk @tychobrailleur
Merge ho7.1 (#1872)
51edf67 
* Release/7 (#1859)

* start HO7.1

* #1856 fix currency of secondary teams

* #1856 fix currency of secondary teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1857 fix playername getter in MatchHighlightsTable (#1860)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1861 fix exception in GoalDiffCriteria (#1864)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* Fix click on “Last Match” column when it has been moved. (#1863)

The “Last Match” column is clickable, and opens:
- The match in Hattrick when shift-clicking,
- The match in HO when double-clicking.

This commit also adds some comment to clarify the behaviour.

* Minor UI improvement in teamAnalyzer. (#1867)

This adds a bit of padding around the check boxes on the teamAnalyser panel,
and centers the automatic / manual radio buttons.

It also cleans up code a bit, in particular in lineup assistant.  Probably more
effort to come on that front.

* #1858 (#1869)

* #1858 debug date time parsing

* #1858 debug currency parsing

* #1858 using Helper.formatCurrency

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 translate comments in Helper.java

* #1858 remove  unused imports in HODateTime.java (add some comments)

* #1858 fix Player.setExpiryDate, use localized DateTimeFormatter

* #1858 fix PlayerConverter add comment explaining offsSpecialty

* #1858 fix PlayerConverter remove old commented methods

* #1858 fix PlayerConverter.parseLocalDateTime

* #1858 PlayerConverter scan wage

* #1858 PlayerConverter scan skill refactored

* #1858 PlayerConverter scan wage
fix indexRowWarning

* Fixes deadline date parsing in Transfer Scout.

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
@wsbrenk wsbrenk closed this as completed May 20, 2023
wsbrenk added a commit that referenced this issue Jun 8, 2023
@wsbrenk @tychobrailleur
Merge7.1 (#1884)
fecf829 
* Release/7 (#1859)

* start HO7.1

* #1856 fix currency of secondary teams

* #1856 fix currency of secondary teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1857 fix playername getter in MatchHighlightsTable (#1860)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1861 fix exception in GoalDiffCriteria (#1864)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* Fix click on “Last Match” column when it has been moved. (#1863)

The “Last Match” column is clickable, and opens:
- The match in Hattrick when shift-clicking,
- The match in HO when double-clicking.

This commit also adds some comment to clarify the behaviour.

* Minor UI improvement in teamAnalyzer. (#1867)

This adds a bit of padding around the check boxes on the teamAnalyser panel,
and centers the automatic / manual radio buttons.

It also cleans up code a bit, in particular in lineup assistant.  Probably more
effort to come on that front.

* #1858 (#1869)

* #1858 debug date time parsing

* #1858 debug currency parsing

* #1858 using Helper.formatCurrency

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 translate comments in Helper.java

* #1858 remove  unused imports in HODateTime.java (add some comments)

* #1858 fix Player.setExpiryDate, use localized DateTimeFormatter

* #1858 fix PlayerConverter add comment explaining offsSpecialty

* #1858 fix PlayerConverter remove old commented methods

* #1858 fix PlayerConverter.parseLocalDateTime

* #1858 PlayerConverter scan wage

* #1858 PlayerConverter scan skill refactored

* #1858 PlayerConverter scan wage
fix indexRowWarning

* Fixes deadline date parsing in Transfer Scout.

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* #1873 (#1874)

* #1873 fix MatchAndLineupSelectionPanel.updateStyleOfPlayComboBox nt team selection

* #1873 release_notes.md

* #1878 (#1879)

* fix OnlineWorker.downloadLastLineup

* MyConnector.downloadPlayerDetails include match info

* #1878 release_notes.md

* #1878 show last match date of nt team players

* #1881 (#1882)

* some cleanup

* #1881 add undocumented goal difference criteria

* #1881 add undocumented goal difference criteria release_notes.md

* #1881 debug worlflow (#1883)

* some cleanup

* #1881 add undocumented goal difference criteria

* #1881 add undocumented goal difference criteria release_notes.md

* #1881 fix workflow

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
wsbrenk added a commit that referenced this issue Jul 22, 2023
@wsbrenk @tychobrailleur
Fix merge (#1896)
080d878 
* Release/7 (#1859)

* start HO7.1

* #1856 fix currency of secondary teams

* #1856 fix currency of secondary teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1857 fix playername getter in MatchHighlightsTable (#1860)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1861 fix exception in GoalDiffCriteria (#1864)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* Fix click on “Last Match” column when it has been moved. (#1863)

The “Last Match” column is clickable, and opens:
- The match in Hattrick when shift-clicking,
- The match in HO when double-clicking.

This commit also adds some comment to clarify the behaviour.

* Minor UI improvement in teamAnalyzer. (#1867)

This adds a bit of padding around the check boxes on the teamAnalyser panel,
and centers the automatic / manual radio buttons.

It also cleans up code a bit, in particular in lineup assistant.  Probably more
effort to come on that front.

* #1858 (#1869)

* #1858 debug date time parsing

* #1858 debug currency parsing

* #1858 using Helper.formatCurrency

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 translate comments in Helper.java

* #1858 remove  unused imports in HODateTime.java (add some comments)

* #1858 fix Player.setExpiryDate, use localized DateTimeFormatter

* #1858 fix PlayerConverter add comment explaining offsSpecialty

* #1858 fix PlayerConverter remove old commented methods

* #1858 fix PlayerConverter.parseLocalDateTime

* #1858 PlayerConverter scan wage

* #1858 PlayerConverter scan skill refactored

* #1858 PlayerConverter scan wage
fix indexRowWarning

* Fixes deadline date parsing in Transfer Scout.

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* #1873 (#1874)

* #1873 fix MatchAndLineupSelectionPanel.updateStyleOfPlayComboBox nt team selection

* #1873 release_notes.md

* #1878 (#1879)

* fix OnlineWorker.downloadLastLineup

* MyConnector.downloadPlayerDetails include match info

* #1878 release_notes.md

* #1878 show last match date of nt team players

* #1881 (#1882)

* some cleanup

* #1881 add undocumented goal difference criteria

* #1881 add undocumented goal difference criteria release_notes.md

* #1881 debug worlflow (#1883)

* some cleanup

* #1881 add undocumented goal difference criteria

* #1881 add undocumented goal difference criteria release_notes.md

* #1881 fix workflow

* Release ho7.1 (#1887)

* release_notes.md update translaation statistics

* release_notes.md

* release HO 7.1

* release_notes.md

* #1889 download new trainer info from player details (#1890)

* stable 7.2 (#1893)

* update README.md (7.2)

* update README.md (7.2)

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
tychobrailleur added a commit to tychobrailleur/HO-t that referenced this issue Sep 16, 2023
@wsbrenk @tychobrailleur
Merge ho7.1 (ho-dev#1872)
4982670 
* Release/7 (ho-dev#1859)

* start HO7.1

* ho-dev#1856 fix currency of secondary teams

* ho-dev#1856 fix currency of secondary teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* ho-dev#1857 fix playername getter in MatchHighlightsTable (ho-dev#1860)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* ho-dev#1861 fix exception in GoalDiffCriteria (ho-dev#1864)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* Fix click on “Last Match” column when it has been moved. (ho-dev#1863)

The “Last Match” column is clickable, and opens:
- The match in Hattrick when shift-clicking,
- The match in HO when double-clicking.

This commit also adds some comment to clarify the behaviour.

* Minor UI improvement in teamAnalyzer. (ho-dev#1867)

This adds a bit of padding around the check boxes on the teamAnalyser panel,
and centers the automatic / manual radio buttons.

It also cleans up code a bit, in particular in lineup assistant.  Probably more
effort to come on that front.

* ho-dev#1858 (ho-dev#1869)

* ho-dev#1858 debug date time parsing

* ho-dev#1858 debug currency parsing

* ho-dev#1858 using Helper.formatCurrency

* ho-dev#1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* ho-dev#1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* ho-dev#1858 translate comments in Helper.java

* ho-dev#1858 remove  unused imports in HODateTime.java (add some comments)

* ho-dev#1858 fix Player.setExpiryDate, use localized DateTimeFormatter

* ho-dev#1858 fix PlayerConverter add comment explaining offsSpecialty

* ho-dev#1858 fix PlayerConverter remove old commented methods

* ho-dev#1858 fix PlayerConverter.parseLocalDateTime

* ho-dev#1858 PlayerConverter scan wage

* ho-dev#1858 PlayerConverter scan skill refactored

* ho-dev#1858 PlayerConverter scan wage
fix indexRowWarning

* Fixes deadline date parsing in Transfer Scout.

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
tychobrailleur added a commit to tychobrailleur/HO-t that referenced this issue Sep 16, 2023
@wsbrenk @tychobrailleur
Merge7.1 (ho-dev#1884)
5a53497 
* Release/7 (ho-dev#1859)

* start HO7.1

* ho-dev#1856 fix currency of secondary teams

* ho-dev#1856 fix currency of secondary teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* ho-dev#1857 fix playername getter in MatchHighlightsTable (ho-dev#1860)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* ho-dev#1861 fix exception in GoalDiffCriteria (ho-dev#1864)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* Fix click on “Last Match” column when it has been moved. (ho-dev#1863)

The “Last Match” column is clickable, and opens:
- The match in Hattrick when shift-clicking,
- The match in HO when double-clicking.

This commit also adds some comment to clarify the behaviour.

* Minor UI improvement in teamAnalyzer. (ho-dev#1867)

This adds a bit of padding around the check boxes on the teamAnalyser panel,
and centers the automatic / manual radio buttons.

It also cleans up code a bit, in particular in lineup assistant.  Probably more
effort to come on that front.

* ho-dev#1858 (ho-dev#1869)

* ho-dev#1858 debug date time parsing

* ho-dev#1858 debug currency parsing

* ho-dev#1858 using Helper.formatCurrency

* ho-dev#1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* ho-dev#1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* ho-dev#1858 translate comments in Helper.java

* ho-dev#1858 remove  unused imports in HODateTime.java (add some comments)

* ho-dev#1858 fix Player.setExpiryDate, use localized DateTimeFormatter

* ho-dev#1858 fix PlayerConverter add comment explaining offsSpecialty

* ho-dev#1858 fix PlayerConverter remove old commented methods

* ho-dev#1858 fix PlayerConverter.parseLocalDateTime

* ho-dev#1858 PlayerConverter scan wage

* ho-dev#1858 PlayerConverter scan skill refactored

* ho-dev#1858 PlayerConverter scan wage
fix indexRowWarning

* Fixes deadline date parsing in Transfer Scout.

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* ho-dev#1873 (ho-dev#1874)

* ho-dev#1873 fix MatchAndLineupSelectionPanel.updateStyleOfPlayComboBox nt team selection

* ho-dev#1873 release_notes.md

* ho-dev#1878 (ho-dev#1879)

* fix OnlineWorker.downloadLastLineup

* MyConnector.downloadPlayerDetails include match info

* ho-dev#1878 release_notes.md

* ho-dev#1878 show last match date of nt team players

* ho-dev#1881 (ho-dev#1882)

* some cleanup

* ho-dev#1881 add undocumented goal difference criteria

* ho-dev#1881 add undocumented goal difference criteria release_notes.md

* ho-dev#1881 debug worlflow (ho-dev#1883)

* some cleanup

* ho-dev#1881 add undocumented goal difference criteria

* ho-dev#1881 add undocumented goal difference criteria release_notes.md

* ho-dev#1881 fix workflow

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
tychobrailleur added a commit to tychobrailleur/HO-t that referenced this issue Sep 16, 2023
@wsbrenk @tychobrailleur
Fix merge (ho-dev#1896)
e7d4b79 
* Release/7 (ho-dev#1859)

* start HO7.1

* ho-dev#1856 fix currency of secondary teams

* ho-dev#1856 fix currency of secondary teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* ho-dev#1857 fix playername getter in MatchHighlightsTable (ho-dev#1860)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* ho-dev#1861 fix exception in GoalDiffCriteria (ho-dev#1864)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* Fix click on “Last Match” column when it has been moved. (ho-dev#1863)

The “Last Match” column is clickable, and opens:
- The match in Hattrick when shift-clicking,
- The match in HO when double-clicking.

This commit also adds some comment to clarify the behaviour.

* Minor UI improvement in teamAnalyzer. (ho-dev#1867)

This adds a bit of padding around the check boxes on the teamAnalyser panel,
and centers the automatic / manual radio buttons.

It also cleans up code a bit, in particular in lineup assistant.  Probably more
effort to come on that front.

* ho-dev#1858 (ho-dev#1869)

* ho-dev#1858 debug date time parsing

* ho-dev#1858 debug currency parsing

* ho-dev#1858 using Helper.formatCurrency

* ho-dev#1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* ho-dev#1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* ho-dev#1858 translate comments in Helper.java

* ho-dev#1858 remove  unused imports in HODateTime.java (add some comments)

* ho-dev#1858 fix Player.setExpiryDate, use localized DateTimeFormatter

* ho-dev#1858 fix PlayerConverter add comment explaining offsSpecialty

* ho-dev#1858 fix PlayerConverter remove old commented methods

* ho-dev#1858 fix PlayerConverter.parseLocalDateTime

* ho-dev#1858 PlayerConverter scan wage

* ho-dev#1858 PlayerConverter scan skill refactored

* ho-dev#1858 PlayerConverter scan wage
fix indexRowWarning

* Fixes deadline date parsing in Transfer Scout.

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* ho-dev#1873 (ho-dev#1874)

* ho-dev#1873 fix MatchAndLineupSelectionPanel.updateStyleOfPlayComboBox nt team selection

* ho-dev#1873 release_notes.md

* ho-dev#1878 (ho-dev#1879)

* fix OnlineWorker.downloadLastLineup

* MyConnector.downloadPlayerDetails include match info

* ho-dev#1878 release_notes.md

* ho-dev#1878 show last match date of nt team players

* ho-dev#1881 (ho-dev#1882)

* some cleanup

* ho-dev#1881 add undocumented goal difference criteria

* ho-dev#1881 add undocumented goal difference criteria release_notes.md

* ho-dev#1881 debug worlflow (ho-dev#1883)

* some cleanup

* ho-dev#1881 add undocumented goal difference criteria

* ho-dev#1881 add undocumented goal difference criteria release_notes.md

* ho-dev#1881 fix workflow

* Release ho7.1 (ho-dev#1887)

* release_notes.md update translaation statistics

* release_notes.md

* release HO 7.1

* release_notes.md

* ho-dev#1889 download new trainer info from player details (ho-dev#1890)

* stable 7.2 (ho-dev#1893)

* update README.md (7.2)

* update README.md (7.2)

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
wsbrenk added a commit that referenced this issue Oct 1, 2023
@wsbrenk @tychobrailleur
Feature/refactor rating prediction (#1920)
260328b 
* team analyzer filter handles challenger cup as friendlies now

* logging RatingPredictionManager

* Speciality.java->specialty

* rating logging

* refactoring RatingPredictionManager

* #1782 start schum rating

* #1782 schum rating

* #1782 RatingPredictionManager teamspirit formula

* #1805 release_notes.md

* typo

* #1782 rating refactoring

* #1782 rating refactoring

* #1782 rating refactoring

* #1782 add experience calculations to strenght cache

* init ratingprediction.json

* json preciction definition

* ratingprediction.json

* start HO7.1

* start HO8.0

* continue

* Release/7 (#1859)

* start HO7.1

* #1856 fix currency of secondary teams

* #1856 fix currency of secondary teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1857 fix playername getter in MatchHighlightsTable (#1860)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1861 fix exception in GoalDiffCriteria (#1864)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* Fix click on “Last Match” column when it has been moved. (#1863)

The “Last Match” column is clickable, and opens:
- The match in Hattrick when shift-clicking,
- The match in HO when double-clicking.

This commit also adds some comment to clarify the behaviour.

* Minor UI improvement in teamAnalyzer. (#1867)

This adds a bit of padding around the check boxes on the teamAnalyser panel,
and centers the automatic / manual radio buttons.

It also cleans up code a bit, in particular in lineup assistant.  Probably more
effort to come on that front.

* #1858 (#1869)

* #1858 debug date time parsing

* #1858 debug currency parsing

* #1858 using Helper.formatCurrency

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 translate comments in Helper.java

* #1858 remove  unused imports in HODateTime.java (add some comments)

* #1858 fix Player.setExpiryDate, use localized DateTimeFormatter

* #1858 fix PlayerConverter add comment explaining offsSpecialty

* #1858 fix PlayerConverter remove old commented methods

* #1858 fix PlayerConverter.parseLocalDateTime

* #1858 PlayerConverter scan wage

* #1858 PlayerConverter scan skill refactored

* #1858 PlayerConverter scan wage
fix indexRowWarning

* Fixes deadline date parsing in Transfer Scout.

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* refactor rating prediction

* #1873 (#1874)

* #1873 fix MatchAndLineupSelectionPanel.updateStyleOfPlayComboBox nt team selection

* #1873 release_notes.md

* ratingprediction formulas (wip)

* #1878 (#1879)

* fix OnlineWorker.downloadLastLineup

* MyConnector.downloadPlayerDetails include match info

* #1878 release_notes.md

* #1878 show last match date of nt team players

* RatingPredictionManager remove debug logs

* new class RatingPredictionModel

* new class RatingPredictionModel

* #1881 (#1882)

* some cleanup

* #1881 add undocumented goal difference criteria

* #1881 add undocumented goal difference criteria release_notes.md

* #1881 debug worlflow (#1883)

* some cleanup

* #1881 add undocumented goal difference criteria

* #1881 add undocumented goal difference criteria release_notes.md

* #1881 fix workflow

* RatingPredictionModel (wip)

* Release ho7.1 (#1887)

* release_notes.md update translaation statistics

* release_notes.md

* release HO 7.1

* release_notes.md

* RatingPredictionModel

* #1889 download new trainer info from player details (#1890)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* stable 7.2 (#1893)

* rating prediction (wip)

* rating prediction (wip)

* #1899 (#1900)

* #1899 training recalculation recovers deleted skill ups

* #1901 PlayerDetailsPanel reset homegrown icon (#1902)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* calcTeamSpirit

* fix RatingChartData

* fix RatingChartData

* fix RatingChartData

* #1849 (#1912)

* ModuleConfigTable.saveConfig

* Update install4j version. (#1906)

This is an attempt at fixing issue #1849 by updating install4j to the latest
version, as it is unclear at this point what is causing the install to hang on
some MacOS machines.

(cherry picked from commit d2a5b0b)

* release-dev INSTALL4J_HOME (#1907)

(cherry picked from commit 628d685)

* https://github.com/ho-dev/HattrickOrganizer (#1911)

(cherry picked from commit 823bfa0)

* #1849 release_notes.md

---------

Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>

* wip

* #1913 fix Player.getMotherclubId

* fit values of RatingPredictionModel.calcSector

* RatingPredictionModel.calcRatingSectorScale

* RatingPredictionModel.calcPlayerScale (wip)

* Player.getPositionRating

* copyrights

* getPlayerMatchAverageRating

* fix edit SubstitutionEditView hatstats update

* fix Substitution.pos

* fix Substitution.setRoleId

* fix RatingPredictionModel.calcStamina

* tune RatingPredictionModel.getRatingSectorScaleFactor

* fix enum coding style

* read.me

* adjust player rating to hatstats formula (factor 3 for midfield contribution)

* implement schum rank

* tychobrailleur's review

* release_notes.md

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
Co-authored-by: Sébastien Le Callonnec <sebastien@weblogism.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsbrenk wsbrenk

Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Milestone
7.1
Development

No branches or pull requests
2 participants
@wsbrenk @johari75