Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check before calling _rescale_discrete_levels #1085

Merged
merged 1 commit into from
May 6, 2022
Merged

Check before calling _rescale_discrete_levels #1085

merged 1 commit into from
May 6, 2022

Conversation

ianthomas23
Copy link
Member

Fixes #1084.

In _interpolate_alpha I wasn't checking before calling _rescale_discrete_levels the same as is done in _interpolate, i.e.

if rescale_discrete_levels and discrete_levels is not None: # Only valid for how='eq_hist'
span = _rescale_discrete_levels(discrete_levels, span)

Test added, and I have checked that there are no other places that _rescale_discrete_levels is called that could cause a similar problem.

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1085 (b5d5dfc) into master (59d1d2d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
+ Coverage   83.35%   83.36%   +0.01%     
==========================================
  Files          34       34              
  Lines        7491     7491              
==========================================
+ Hits         6244     6245       +1     
+ Misses       1247     1246       -1     
Impacted Files Coverage Δ
datashader/transfer_functions/__init__.py 86.61% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d1d2d...b5d5dfc. Read the comment docs.

@jbednar jbednar merged commit ca9d3f3 into holoviz:master May 6, 2022
@philippjfr philippjfr added this to the v0.14.1 milestone Jun 10, 2022
@ianthomas23 ianthomas23 modified the milestones: v0.14.2, v0.14.1 Jul 18, 2022
@ianthomas23 ianthomas23 deleted the issue_1084 branch July 19, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: interpolator did not return a valid discrete_levels
3 participants