Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional Esri tile sources #176

Merged
merged 3 commits into from May 17, 2018
Merged

Added additional Esri tile sources #176

merged 3 commits into from May 17, 2018

Conversation

@jbednar
Copy link
Member

jbednar commented May 16, 2018

There are several Esri tile sources that are useful in addition to those included, and this PR adds them with the attributions as listed on the ArcGIS websites:

This PR also fixes broken attributions caused by malformed tuples for cartodb and cartocdn. Finally, it renames ESRI to EsriImagery, to reflect that there are many Esri map servers, though the original name is preserved for compatibility with the 1.5 gv release.

jbednar added 2 commits May 16, 2018
@jbednar jbednar requested a review from philippjfr May 16, 2018
Copy link
Member

philippjfr left a comment

Looks great thanks!

@jbednar jbednar merged commit 584f3f3 into master May 17, 2018
0 of 5 checks passed
0 of 5 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
coverage/coveralls Coverage pending from Coveralls.io
Details
@jbednar jbednar deleted the tiles branch May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.