Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color bar limit opt and redim range if values are equal. #3382

Merged
merged 8 commits into from
Jan 15, 2019

Conversation

ahuang11
Copy link
Collaborator

Addresses #3373 and #3350 and isn't in the same PR as #3381 because I wasn't sure if the extra computations are worth it for the warnings.

@ahuang11
Copy link
Collaborator Author

ahuang11 commented Jan 13, 2019

image
image

@ahuang11 ahuang11 changed the title Add image warnings Add color bar limit opt and redim range if values are equal. Jan 13, 2019
@ahuang11 ahuang11 mentioned this pull request Jan 13, 2019
@ahuang11
Copy link
Collaborator Author

image

@philippjfr
Copy link
Member

@ahuang11 I've made one more comment. If we want to get the tests passing you'll likely also have to rebase once #3392 is merged. Some change in NumPy 1.16 is playing havoc with our python 2 tests.

@philippjfr
Copy link
Member

Thanks it's looking good, I'll handle the rebasing once the other PR is merged.

@philippjfr philippjfr merged commit 35ce68c into master Jan 15, 2019
@philippjfr philippjfr deleted the add_image_warnings branch April 29, 2019 11:26
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants