Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color bar limit opt and redim range if values are equal. #3382

Merged
merged 8 commits into from Jan 15, 2019

Conversation

@ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Jan 12, 2019

Addresses #3373 and #3350 and isn't in the same PR as #3381 because I wasn't sure if the extra computations are worth it for the warnings.

@ahuang11
Copy link
Collaborator Author

@ahuang11 ahuang11 commented Jan 13, 2019

image
image

@ahuang11 ahuang11 changed the title Add image warnings Add color bar limit opt and redim range if values are equal. Jan 13, 2019
@ahuang11 ahuang11 mentioned this pull request Jan 13, 2019
@ahuang11
Copy link
Collaborator Author

@ahuang11 ahuang11 commented Jan 13, 2019

image

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 15, 2019

@ahuang11 I've made one more comment. If we want to get the tests passing you'll likely also have to rebase once #3392 is merged. Some change in NumPy 1.16 is playing havoc with our python 2 tests.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 15, 2019

Thanks it's looking good, I'll handle the rebasing once the other PR is merged.

@philippjfr philippjfr force-pushed the add_image_warnings branch from 81bc431 to 5c2080d Jan 15, 2019
@philippjfr philippjfr merged commit 35ce68c into master Jan 15, 2019
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 89.856%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the add_image_warnings branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants