Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes when specifying both data_aspect and responsive modes #3575

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Fixes when specifying both data_aspect and responsive modes #3575

merged 3 commits into from
Mar 25, 2019

Conversation

philippjfr
Copy link
Member

Fixes a number of bugs in handling of aspect and responsive modes:

  • Ensures that if data_aspect zoom tools are always locked
  • Fixes inverted aspect_ratio when responsive=True
  • Ensure that aspect is applied even if data_aspect is set

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Mar 24, 2019
@philippjfr philippjfr merged commit 031a39a into master Mar 25, 2019
@jlstevens
Copy link
Contributor

Thanks, I just tested it and the horrible stretched layout is gone and it now works great!

@philippjfr philippjfr deleted the layout_aspect_fixes branch April 29, 2019 11:24
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @jlstevens