Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcparam datapath deprecated in mpl 3.2.1 #4335

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Conversation

poplarShift
Copy link
Collaborator

@poplarShift poplarShift commented Mar 30, 2020

See holoviz/geoviews#452

This whole code to handle deprecated rcparams is now being duplicated in renderer.py and plot.py, should probably factor that out somehow?

https://matplotlib.org/3.2.1/api/prev_api_changes/api_changes_3.2.0.html#the-datapath-rcparam

@poplarShift poplarShift changed the title datapath deprecated in 3.2.1 rcparam datapath deprecated in mpl 3.2.1 Mar 30, 2020
@philippjfr
Copy link
Member

Much appreciated. I'm not sure what's up with travis and the appveyor tests are flakey as hell so I'm merging.

@philippjfr philippjfr merged commit adbae0e into master Mar 30, 2020
@philippjfr
Copy link
Member

This whole code to handle deprecated rcparams is now being duplicated in renderer.py and plot.py, should probably factor that out somehow

Yes, want to make an issue?

@philippjfr philippjfr mentioned this pull request Apr 1, 2020
@philippjfr philippjfr deleted the rcparam_datapath branch April 25, 2022 14:40
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants