Align Bars with annotations on matplotlib #5024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align the bars with the annotations such as ErrorBars or Labels. Fixes holoviz#4989
douglas-raillard-arm
force-pushed
the
fix_bar_align
branch
from
9884202
to
631babe
Compare
|
Not 100% sure if that fixes the issue in all paths |
|
I agree this seems like the right fix, the only worry I have here is that users in the past may have worked around the issue and now we're breaking all their workarounds. |
|
Maybe an explicit changelog entry would solve that problem so that people are aware they can remove their workaround ? |
philippjfr
reviewed
May 17, 2024
|
Looks like this was already fixed in #6145 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the bars with the annotations such as ErrorBars or Labels.
Fixes #4989