Wrap popup in set_curdoc #6337
Merged
Wrap popup in set_curdoc #6337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, test failures are unrelated. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6337 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 323 323
Lines 68092 68093 +1
=======================================
+ Hits 60262 60263 +1
Misses 7830 7830 ☔ View full report in Codecov by Sentry. |
|
Thank you for the PR! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversation in #6332 , this change wraps the popup call in a
set_curdoccontext so that the document inside the popup is valid. I am the original reporter of this issue and making the PR from my personal account.