Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the home page #876

Merged
merged 11 commits into from
Nov 23, 2022
Merged

Improve the home page #876

merged 11 commits into from
Nov 23, 2022

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Aug 28, 2022

@hoxbro
Copy link
Member

hoxbro commented Aug 29, 2022

I have updated your comment to link to the original issues; see Development on the side:
image

If you end up not fixing an issue, you should remove the Fixes from the comment.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Aug 29, 2022

Ahh. Thanks. Ok. I've never noticed any one using that before in the HoloViz projects. But going to some old PRs I can see it is being used.

Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarcSkovMadsen , I've made some comments. If you accept my suggestion on the Pandas example, the corresponding GIF would have to be updated. I could take care of it if you like.

doc/index.md Outdated Show resolved Hide resolved
doc/index.md Outdated Show resolved Hide resolved
doc/index.md Show resolved Hide resolved
doc/index.md Outdated Show resolved Hide resolved
doc/index.md Outdated Show resolved Hide resolved
doc/index.md Outdated Show resolved Hide resolved
MarcSkovMadsen and others added 6 commits October 11, 2022 16:40
Co-authored-by: Maxime Liquet <35924738+maximlt@users.noreply.github.com>
Co-authored-by: Maxime Liquet <35924738+maximlt@users.noreply.github.com>
Co-authored-by: Maxime Liquet <35924738+maximlt@users.noreply.github.com>
@MarcSkovMadsen MarcSkovMadsen marked this pull request as ready for review October 11, 2022 16:55
@maximlt
Copy link
Member

maximlt commented Nov 23, 2022

Thanks a lot Marc, I've only made some small changes.

@maximlt maximlt merged commit 091cf55 into holoviz:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants