-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements to the DateFilter widget #276
Conversation
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 65.42% 65.22% -0.20%
==========================================
Files 57 57
Lines 5611 5628 +17
==========================================
Hits 3671 3671
- Misses 1940 1957 +17
Continue to review full report at Codecov.
|
This is ready for review @philippjfr The accumulating calls to A few other PRs were required to get this properly working:
|
@philippjfr I've reworked this PR quite a bit, c89cb89 is where you can see all the changes I've made. Based on our discussion and the write-up in #293, I've implemented There are a couple of decisions I've made which we'll need your approval:
It'd probably be worth:
|
c89cb89
to
c95c7e2
Compare
Adding tests separately. Thanks @maximlt! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Includes various fixes to the
DateFilter
:datetime.date
value
Parameter by aCalendarDate
orDateRange
Parameters (let me know if there's a better way, that looks hacky!)value
Parameter, this allows URL query parameter changes to be synced back to the widget.This is work in progress and requires other changes both in Param and Panel. I've also noticed accumulating calls in
get_data
on picker mode so there's something wrong there.