Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align output of the TableAgent and the SQLAgent #687

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

philippjfr
Copy link
Member

  • Ensures that the output of the TableAgent and SQLAgent are handled the same way
  • Remove the hardcoded instruction to add LIMIT to the SQL query and instead add a SQLLimit transform which can be toggled in the UI
  • Cache the SQL output

@philippjfr philippjfr merged commit f8b02ee into main Aug 22, 2024
10 checks passed
@philippjfr philippjfr deleted the sql_output_tweaks branch August 22, 2024 08:59
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 56.66%. Comparing base (eb31bc8) to head (3e98518).
Report is 1 commits behind head on main.

Files Patch % Lines
lumen/ai/views.py 0.00% 30 Missing ⚠️
lumen/ai/agents.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
- Coverage   56.69%   56.66%   -0.03%     
==========================================
  Files          98       98              
  Lines       11677    11682       +5     
==========================================
  Hits         6620     6620              
- Misses       5057     5062       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant