-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements and Documentation for Panes #313
Conversation
47658b4
to
938c35f
Compare
938c35f
to
16b4128
Compare
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
========================================
- Coverage 89.29% 89.2% -0.1%
========================================
Files 67 67
Lines 6622 6696 +74
========================================
+ Hits 5913 5973 +60
- Misses 709 723 +14
Continue to review full report at Codecov.
|
So after refactoring the various models I now realize that loading the JS in this does not work for the classic notebook as noted in bokeh/bokeh#5227. Not sure what to do about this yet, but it may require a fallback condition implemented using jQuery or similar. |
In the worst case scenario which is that we find no non-hacky solution that could be added to bokeh itself I will likely just insert this hack in our JS: if (window.requirejs) {
window._define = window.define;
// Stub does not define amd and is therefore skipped by UMD loaders
// however Notebook bundle does not check for window.define.amd
function _define_stub(name, deps, callback) {
window._define(name, deps, callback)
}
window.define = _define_stub;
function _reset_define() {
window.define = window._define;
}
window._bokeh_onload_callbacks.push(_reset_define)
} It temporarily replaces |
I decided to trial a fix for the issue loading dependencies in classic notebooks by adding a @xavArtley If you want the VTK model to work in the classic notebook you'll be able to add something like this to your VTK model to load vtk.js correctly: __js_require__ = {"paths": {"vtk": "//unpkg.com/vtk.js@8.3.15/dist/vtk"},
"shim": {"vtk": {"exports": "vtk"}}} |
This PR provides polish to all existing pane classes and then adds reference sections for each. I'll outline all the panes and the improvements made here: