Allow defining external JS and CSS resources via config #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good; could use some docs and examples! |
philippjfr
force-pushed
the
external_js_css
branch
from
fe118f5
to
2ac399a
Compare
|
Added some docs. |
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
- Coverage 89.55% 89.47% -0.08%
==========================================
Files 84 85 +1
Lines 6795 6824 +29
==========================================
+ Hits 6085 6106 +21
- Misses 710 718 +8
Continue to review full report at Codecov.
|
|
Merging, I'd suggest you review the documentation as a whole before release @jbednar. |
jbednar
reviewed
Mar 24, 2019
| "\n", | ||
| " pn.extension('vega', 'katex')\n", | ||
| " \n", | ||
| "will ensure that the Vega and LaTeX JS dependencies are loaded. Additionally any external ``css_files``, ``js_files`` and ``raw_css`` should be declared in the extension. The ``js_files`` should be declared as a dictionary mapping from the exported JS module name to the URL containing the JS components, while the ``css_files`` can be defined as a list:\n", |
There was a problem hiding this comment.
I know this is already merged, but while it's still fresh in your mind, it would be good to clarify the situations where one would need external CSS or JS files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.