Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signature of bokeh.io.export.export_png #1165

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

Guillemdb
Copy link
Contributor

The bokeh.io.export.export.export_png function has been updated, and now filename needs to be passes as a keyword argument.

  • This PR updates the filename parameter passed to the function to reflect the update of the export_png signature.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #1165 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1165   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files         105      105           
  Lines       12591    12591           
=======================================
  Hits        11057    11057           
  Misses       1534     1534           
Impacted Files Coverage Δ
panel/io/save.py 82.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602e467...17e14c7. Read the comment docs.

@philippjfr
Copy link
Member

Thanks @Guillemdb!

@philippjfr philippjfr added this to the v0.9.2 milestone Mar 19, 2020
@philippjfr philippjfr merged commit 75fa0f1 into holoviz:master Mar 19, 2020
@mattpap
Copy link
Collaborator

mattpap commented Mar 19, 2020

As an FYI, all APIs in bokeh will get keyword only args (if needed) in 3.0. I think it's a good idea to start writing code now that uses the APIs as if this was done already. This will simplify transition to the next major version.

@philippjfr
Copy link
Member

Thanks for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants