Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fileupload with Pandas and Plotly example #1193

Merged

Conversation

MarcSkovMadsen
Copy link
Collaborator

This notebook was contributed as an answer to the question A button to upload csv file and plot it on Discourse

@philippjfr
Copy link
Member

Fabulous, but this should probably go in examples/gallery/param or we could rethink the categories. I should also probably provide descriptions on what the categories were meant to be, external was meant as any external component loaded into Panel using custom css and js_files and the HTML pane, e.g. your Folium example could go in there.

@MarcSkovMadsen
Copy link
Collaborator Author

I have cleaned it up and moved it to param folder. I will not do more before for now. But if there are helpfull suggestions I will.

But there is one bug i cannot solve

#1195

The example looks like

file_upload

@philippjfr
Copy link
Member

Please also clear the notebook before committing it.

@MarcSkovMadsen
Copy link
Collaborator Author

I've cleared the output and committed it @philippjfr

@philippjfr
Copy link
Member

Same error as in the Folium example, can't find a sample_data.csv.

@philippjfr philippjfr modified the milestones: v1.0.0, v0.9.5 Apr 2, 2020
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #1193 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1193   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         106      106           
  Lines       12627    12627           
=======================================
  Hits        11041    11041           
  Misses       1586     1586           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e47d2...93587f0. Read the comment docs.

@philippjfr philippjfr force-pushed the file-upload-with-pandas-and-plotting branch from ecdfdad to 93587f0 Compare April 2, 2020 19:23
@philippjfr
Copy link
Member

Thanks!

@philippjfr philippjfr merged commit 9fb95e3 into holoviz:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants