Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Template.save #1224

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Implement Template.save #1224

merged 2 commits into from
Apr 3, 2020

Conversation

philippjfr
Copy link
Member

Partially addresses #1066

This does not yet support embedding which is what the original issue requested. It does however lay the groundwork for that.

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #1224 into master will decrease coverage by 0.13%.
The diff coverage is 35.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
- Coverage   87.44%   87.30%   -0.14%     
==========================================
  Files         106      106              
  Lines       12632    12662      +30     
==========================================
+ Hits        11046    11055       +9     
- Misses       1586     1607      +21     
Impacted Files Coverage Δ
panel/template.py 63.97% <33.33%> (-2.97%) ⬇️
panel/io/save.py 57.33% <37.03%> (-9.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa14739...e49b69e. Read the comment docs.

@philippjfr philippjfr merged commit d9d6241 into master Apr 3, 2020
@philippjfr philippjfr deleted the template_save branch April 3, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant