FileDownload widget: Allow callback to update filename #1246
Conversation
Let me know how that goes, I've still not been able to reproduce any of those issues myself. |
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
==========================================
+ Coverage 87.30% 87.71% +0.40%
==========================================
Files 106 124 +18
Lines 12662 13228 +566
==========================================
+ Hits 11055 11603 +548
- Misses 1607 1625 +18
Continue to review full report at Codecov.
|
Ok I'll try to provide some more context. I installed When I open a notebook, before running any code, I see this error in the console: Then if I try to run something like: import panel as pn
pn.extension()
w = pn.pane.Markdown("# Hey")
w.show()I see the following errors in the console: In the opened browser tab, there's nothing displayed. The browser console shows: And if that can be useful in some way, my full env spec: |
|
Did you rebuild the panel.js bundle after you updated your env? Try running: in the root of the repo. |
|
I've just tried: which gives: But the error was still there. So I tried: which gave: Still the same error. I've deleted the Let me know if I can do some other tests for you (tomorrow!). |
|
Okay, well that's not good. I'll make a completely fresh env tomorrow and will try reproducing it again. |
|
The PR looks good apart from one minor comment. I guess you can't continue until the bokeh issue is fixed? |
|
Hi @philippjfr! Thanks for spotting that typo! I decided to submit that first PR as it solves the issue I had originally. I can now set the filename in a callback which is pretty handy. For instance, now one can append the current datetime to the output filename in a callback. I've been working on a second PR whose aim is to fix some other issues with the widget. Since it deals with the Typescript side of the widget, it's a slower process for me as I know pretty much nothing about that. It's also quite slow as I have to build everything first and then run a python script, there's maybe a faster way. I'd suggest that you merge this PR first. Hopefully in the next few days will come a second PR. |
|
Okay, great. Thanks again! |
Hi!
I've started to work on fixing #1236, to try to better understand the code I started with adding some more tests and error handling.
As I found a way to update the
filenameparameter from the callback as side-effect (this is what I intended to do in #1236), I've decided to submit this first batch of work as a PR.I plan to submit another PR in the next days, trying to fix completely #1236.
(I was also hindered by these
Model 'panel.models.widgets.FileDownload' does not existerrors while trying to launch a Bokeh server, error that is probably related to the recent problems around that, I'll try to update my setup and see how it goes).