-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add busy/loading indicators and enable on Template #1493
Conversation
175171a
to
4895257
Compare
Awesome. Will it be possible to easily set a custom color? In general it would be nice to set a custom color for the different button_type, booleanstatus_type, loadingspinner_type etc.. In an organisation there is normally some kind of branding guide you need to follow. It would be nice to set that style in one place instead of many places. Setting it in CSS if it is easy would also be a good solution. In some of the material frameworks you can set |
64554fc
to
b2469de
Compare
No, this is currently not supported and can't be easily supported until we improve the way CSS is handled and built. I have plans to switch to something like Sass and compile the CSS properly but for now defining preset colors is the best we can do. |
04f47e3
to
9d527d7
Compare
That is definitely going to be part of that CSS refactoring work. |
Codecov Report
@@ Coverage Diff @@
## master #1493 +/- ##
==========================================
+ Coverage 86.09% 86.31% +0.22%
==========================================
Files 141 142 +1
Lines 15656 15766 +110
==========================================
+ Hits 13479 13609 +130
+ Misses 2177 2157 -20
Continue to review full report at Codecov.
|
Adds two boolean indicators which can be used independently or in one of the default templates.
BooleanStatus
LoadingSpinner
Template
Here we can see the indicator on the right of the template header.