Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding and deleting Location component #1519

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 7, 2020

The Location component lookup was broken in certain scenarios causing errors.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #1519 into master will decrease coverage by 0.03%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
- Coverage   85.66%   85.62%   -0.04%     
==========================================
  Files         144      144              
  Lines       15951    15959       +8     
==========================================
+ Hits        13664    13665       +1     
- Misses       2287     2294       +7     
Impacted Files Coverage Δ
panel/viewable.py 70.79% <0.00%> (ø)
panel/io/location.py 80.89% <12.50%> (-6.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0603c36...53694b9. Read the comment docs.

@philippjfr philippjfr merged commit 40e6c69 into master Aug 7, 2020
@philippjfr philippjfr deleted the location_fix branch August 7, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant