Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo option for BaseTemplates #1608

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Add logo option for BaseTemplates #1608

merged 1 commit into from
Oct 5, 2020

Conversation

philippjfr
Copy link
Member

Adds ability to add logo to template directly rather than using Panel objects, which were difficult to align correctly.

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #1608 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
+ Coverage   85.63%   85.80%   +0.16%     
==========================================
  Files         147      147              
  Lines       16488    16959     +471     
==========================================
+ Hits        14119    14551     +432     
- Misses       2369     2408      +39     
Impacted Files Coverage Δ
panel/pane/image.py 75.48% <ø> (-4.94%) ⬇️
panel/template/base.py 72.18% <ø> (-0.45%) ⬇️
panel/pane/vtk/synchronizable_serializer.py 86.69% <0.00%> (+1.98%) ⬆️
panel/pane/vtk/vtk.py 96.32% <0.00%> (+2.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc0fb9...bfaba20. Read the comment docs.

@philippjfr philippjfr merged commit e6ca798 into master Oct 5, 2020
@philippjfr philippjfr deleted the template_logo branch October 5, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant