Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location sync #1788

Closed
wants to merge 1 commit into from
Closed

Fix location sync #1788

wants to merge 1 commit into from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 15, 2020

This is a fix to the location sync mentioned in #1784.

I have not done this for any other widgets than DatePicker, because I don´t know if there is a smarter way to do it, if there is let me know. Also need to create unit test for it.

animated

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #1788 (b147e99) into master (b47ca33) will decrease coverage by 0.00%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1788      +/-   ##
==========================================
- Coverage   85.13%   85.12%   -0.01%     
==========================================
  Files         151      151              
  Lines       17923    17932       +9     
==========================================
+ Hits        15258    15264       +6     
- Misses       2665     2668       +3     
Impacted Files Coverage Δ
panel/io/location.py 83.78% <50.00%> (-0.62%) ⬇️
panel/widgets/input.py 95.59% <77.77%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47ca33...b147e99. Read the comment docs.

@hoxbro hoxbro marked this pull request as draft November 16, 2020 06:12
@philippjfr
Copy link
Member

The correct way to do this will be to get this into the param serialization framework.

@philippjfr
Copy link
Member

In fact this is already correctly implemented in param, so not quite sure why the deserialize call shouldn't work.

@philippjfr philippjfr closed this Nov 17, 2020
@hoxbro hoxbro deleted the sync_issue branch November 17, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants