Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with Ace z-index #2126

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Fix issues with Ace z-index #2126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions panel/models/ace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""
Defines custom AcePlot bokeh model to render Ace editor.
"""
from bokeh.core.properties import String, Override, Dict, Any, List, Bool, Enum
from bokeh.core.properties import String, Override, Dict, Any, List, Bool, Enum, Nullable
from bokeh.models import HTMLBox

from ..io.resources import bundled_files
Expand Down Expand Up @@ -50,7 +50,7 @@ def __js_skip__(cls):

theme = Enum(ace_themes, default='chrome')

filename = String()
filename = Nullable(String())

language = String()

Expand Down
3 changes: 2 additions & 1 deletion panel/models/ace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ export class AcePlotView extends PanelHTMLBoxView {
id: ID(),
style: {
width: "100%",
height: "100%"
height: "100%",
zIndex: 0,
}
})
}
Expand Down