Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parameter definition order for Python 3.6+ #238

merged 4 commits into from Feb 14, 2019


Copy link

@jlstevens jlstevens commented Feb 12, 2019

Since Python dictionaries preserve order since 3.6 (and it became part of the CPython spec in 3.7), you no longer have to use parameter precedence to order your widgets as they can appear in definition order. This PR implements this behavior for Python 3.6+.

Copy link
Contributor Author

@jlstevens jlstevens commented Feb 12, 2019

@philippjfr I think this is ready to merge once the tests pass.

panel/ Show resolved Hide resolved
panel/ Outdated Show resolved Hide resolved
Copy link

@philippjfr philippjfr commented Feb 14, 2019

Thanks for making the requested changes.

@philippjfr philippjfr merged commit 122093a into master Feb 14, 2019
3 checks passed
@philippjfr philippjfr deleted the param_definition_order branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants