Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure external resources are configured correctly on save #2452

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

philippjfr
Copy link
Member

Fixes #2367

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #2452 (984a946) into master (c80db0d) will increase coverage by 0.01%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2452      +/-   ##
==========================================
+ Coverage   83.39%   83.40%   +0.01%     
==========================================
  Files         182      183       +1     
  Lines       22739    22759      +20     
==========================================
+ Hits        18963    18983      +20     
  Misses       3776     3776              
Impacted Files Coverage Δ
panel/io/save.py 59.82% <77.77%> (+2.03%) ⬆️
panel/tests/io/test_save.py 100.00% <100.00%> (ø)
panel/io/resources.py 76.23% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80db0d...984a946. Read the comment docs.

@philippjfr philippjfr merged commit db57c8e into master Jun 29, 2021
@philippjfr philippjfr deleted the save_resources branch June 29, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Altair plots cannot be embedded into html when panel is run from a script
1 participant