-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ICO and pathlib support for image #2757
Conversation
Not sure it's worth it to make a reference gallery item for ICO but we need to exclude it from the unit test that checks such an example exists. |
Codecov Report
@@ Coverage Diff @@
## master #2757 +/- ##
==========================================
+ Coverage 82.03% 82.67% +0.63%
==========================================
Files 187 188 +1
Lines 23963 24070 +107
==========================================
+ Hits 19658 19899 +241
+ Misses 4305 4171 -134
Continue to review full report at Codecov.
|
I don't either see the need for a reference gallery item. Should I also make the logo in BasicTemplate accept pathlib? |
Yes, but maybe in a separate PR. |
* Added icon pane * Added f to string * Added pathlib for images and template favicon * Added tests * Removed ICO from test_panes_are_in_reference_gallery
Without a reference example, how would users know its supported? And what potential arguments are available? |
I'm not opposed to adding a reference gallery of ICO. Though, I don't think anybody will ever use an ICO pane directly but will rather pass a path or URL of an |
Added a
ICO
class topane.image
andpathlib
conversion to pane.image and favicon in templates.