-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly load plotly and vega libraries #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
approved these changes
Mar 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 89.1% 89.28% +0.17%
==========================================
Files 63 65 +2
Lines 6583 6617 +34
==========================================
+ Hits 5866 5908 +42
+ Misses 717 709 -8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I used some horrible code to load plotly and vega dynamically when the models are used. Not only is this horrible, it also doesn't seem to work when exported in a notebook. This PR instead uses the
__javascript__
variable on the models, which loads vega and plotly js when the extension is loaded. To avoid it being loaded all the time these models are no longer imported by default, instead the corresponding Pane objects do the import dynamically. This works fine in server and commandline use cases but in the notebook the models need to be imported before the extension is run. Therefore I have added the ability to load these models via the extension, much like in holoviews. So you can now dopn.extension('vega')
and it will load vega js in the notebook.