Do not re-render Tabulator on css_classes or background change #3598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
LayoutDOMView
in bokeh issuesinvalidate_render
events whenever either thecss_classes
or thebackground
change. This is IMO kind of nuts since it's potentially quite expensive and slow, although I understand that it's strictly the safest approach becausecss_classes
can affect the size of the components and more. However we usecss_classes
extensively, e.g. for setting and unsetting the loading spinners. This PR disconnects theinvalidate_render
event specifically for theTabulator
widget. I'm not happy about this since really this is something that needs to be better handled in Bokeh or we should find a general mechanism to improve how theloading
parameter is handled by Panel components but for now this avoids annoying layout issues.