Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not re-render Tabulator on css_classes or background change #3598

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 9, 2022

Currently LayoutDOMView in bokeh issues invalidate_render events whenever either the css_classes or the background change. This is IMO kind of nuts since it's potentially quite expensive and slow, although I understand that it's strictly the safest approach because css_classes can affect the size of the components and more. However we use css_classes extensively, e.g. for setting and unsetting the loading spinners. This PR disconnects the invalidate_render event specifically for the Tabulator widget. I'm not happy about this since really this is something that needs to be better handled in Bokeh or we should find a general mechanism to improve how the loading parameter is handled by Panel components but for now this avoids annoying layout issues.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3598 (c000bb0) into master (6752cd5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3598      +/-   ##
==========================================
- Coverage   82.71%   82.71%   -0.01%     
==========================================
  Files         202      202              
  Lines       27585    27585              
==========================================
- Hits        22817    22816       -1     
- Misses       4768     4769       +1     
Impacted Files Coverage Δ
panel/io/server.py 76.35% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6752cd5...c000bb0. Read the comment docs.

@philippjfr philippjfr merged commit 2b161b2 into master Jun 9, 2022
@philippjfr philippjfr deleted the tabulator_loading_rerender branch June 9, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant