Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression initializing DiscreteSlider with non-integer value #4009

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

philippjfr
Copy link
Member

Fixes #3965

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #4009 (0acb130) into master (00f6f33) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4009      +/-   ##
==========================================
- Coverage   83.67%   83.67%   -0.01%     
==========================================
  Files         223      223              
  Lines       33128    33130       +2     
==========================================
+ Hits        27719    27720       +1     
- Misses       5409     5410       +1     
Flag Coverage Δ
ui-tests 37.57% <0.00%> (-0.02%) ⬇️
unitexamples-tests 74.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/widgets/test_player.py 100.00% <100.00%> (ø)
panel/widgets/player.py 79.06% <100.00%> (+0.49%) ⬆️
panel/tests/util.py 88.34% <0.00%> (-0.98%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 00a4f30 into master Oct 15, 2022
@philippjfr philippjfr deleted the player_value_throttled branch October 15, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: DiscretePlayer now only accept integers as options
1 participant