Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Reference doc improvements #5934

Merged
merged 2 commits into from
Nov 29, 2023
Merged

SVG Reference doc improvements #5934

merged 2 commits into from
Nov 29, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Nov 29, 2023

I primarely wanted to get the Panel green logo updated to Panel blue. But then took the chance to make things a bit more specific.

If you want to keep the original link to the Panel logo you should update the link link https://assets.holoviz.org/panel/samples/svg_sample.svg to the Panel blue logo. I cannot do that.

@MarcSkovMadsen MarcSkovMadsen added this to the v1.3.3 milestone Nov 29, 2023
@MarcSkovMadsen MarcSkovMadsen changed the title Improve SVG Reference doc SVG Reference doc improvements Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59c7d83) 84.19% compared to head (a856f07) 82.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5934      +/-   ##
==========================================
- Coverage   84.19%   82.62%   -1.57%     
==========================================
  Files         291      291              
  Lines       42907    42907              
==========================================
- Hits        36127    35454     -673     
- Misses       6780     7453     +673     
Flag Coverage Δ
ui-tests 38.40% <ø> (-2.45%) ⬇️
unitexamples-tests 72.49% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 68e0070 into main Nov 29, 2023
10 of 13 checks passed
@philippjfr philippjfr deleted the enhancement/svg branch November 29, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants