Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the ReactiveExpr reference guide #5960

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Nov 30, 2023

I had problems understanding the new ReactiveExpr pane from the reference guide. Especially how to layout things.

During that process I discovered that one of the problems is that default_layout is mentioned in the reference guide. And it should not be. See #5948. This PR will be Closing #5948 .

I added more small examples to help the user understand what reactive expressions are and how powerful they can be.

I added in emojis. I know some people think its too much. But I just think they communicate better when you open up the notebook during a training session, a conference talk or if you record a video for social media. I also believe that users when studying the notebook feel its more fun and engaging to study. For the same reason I used the material design.

Todo

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (905cf91) 82.54% compared to head (8c5c123) 84.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5960      +/-   ##
==========================================
+ Coverage   82.54%   84.32%   +1.78%     
==========================================
  Files         291      291              
  Lines       43348    43348              
==========================================
+ Hits        35781    36555     +774     
+ Misses       7567     6793     -774     
Flag Coverage Δ
ui-tests 40.89% <100.00%> (+2.42%) ⬆️
unitexamples-tests 72.39% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Nov 30, 2023

Assets

Here is a little bit for the social media

param-rx-examples.mp4
param-reactive-expressions-layout.mp4
panel-reactive-expression-reference-example.mp4

panel-reactive-expression-refere
param-reactive-expressions-layou
param-rx-examples

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@philippjfr philippjfr merged commit a3c6a96 into main Dec 1, 2023
13 checks passed
@philippjfr philippjfr deleted the enhancement/reactiveexpr-reference-guide branch December 1, 2023 11:12
@philippjfr philippjfr modified the milestones: v1.4.0, v1.3.5 Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default_layout of ReactiveExpr not working
2 participants